-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update hooks guide reference #35503
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
Thanks for the pull request, @emmanuel-ferdman! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @emmanuel-ferdman, thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form, as mentioned above. Thanks! |
Hi @emmanuel-ferdman! Just checking in to see if you plan to pursue this pull request? If so, please let me know if you have submitted a CLA form. Thanks! |
Hi @emmanuel-ferdman! I believe you submitted your CLA form, so I'm just checking in to see if you plan to pursue this pull requeest? |
@mphilbrick211 yes I submitted the CLA, not sure why the test does not pass |
@emmanuel-ferdman I'll have someone on our end enable tests again for you! |
@emmanuel-ferdman all set on the tests. Regarding the CLA form, you should have received an email back in September requesting more information for your form. Please see if you received it, and if you can't find it, I can resend. |
Description
Commit 3e2d78b moved
docs/guides/hooks/index.rst
todocs/hooks/index.rst
. This PR adjusts sources to changes.